-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add BROWSERS_IMAGE_SHORT_TAG #1256
feat: add BROWSERS_IMAGE_SHORT_TAG #1256
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
77ee872
to
b0c0841
Compare
There is no problem to use
Only the use of the Modified in b0c0841 |
Update - CHROME_VERSION to 131.0.6778.85-1 - EDGE_VERSION to 131.0.2903.70-1
The next planned full version releases of Chromium browsers is not until Jan 2025, so updating browsers to latest current patch versions to trigger creation of Update
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. Will be looking out for part 2
Thanks for your approval! 🙂
Docker Hub repo cypress/browsers shows the short-form image tag is now published: docker pull cypress/browsers:22.11.0
|
Issue
The
BROWSERS_IMAGE_TAG
used for thecypress/browsers
Docker image in the formnode-<NODE_VERSION>-chrome-<CHROME_VERSION>-ff-<FIREFOX_VERSION>-edge-<EDGE_VERSION>
for example
cypress/browsers:node-22.11.0-chrome-131.0.6778.69-1-ff-132.0.2-edge-131.0.2903.51-1
is not supported by the Renovate Docker update function, since it does not look like a simple version tag. The tag is also inconveniently long when shown in examples and documentation.
Other Cypress Docker images, intended for external use, each have a Renovate-Docker compatible tag.
cypress/factory
FACTORY_VERSION
5.1.0
cypress/base
BASE_IMAGE_TAG
22.11.0
cypress/included
INCLUDED_IMAGE_SHORT_TAG
13.16.0
cypress/browsers
is currently missing a Renovate-Docker-compatible tag.Change
A new tag
BROWSERS_IMAGE_SHORT_TAG
is added tocypress/browsers
with the formNODE_VERSION
for example
cypress/browsers:22.11.0
.The existing tag
BROWSERS_IMAGE_TAG
remains as the main immutable tag forcypress/browsers
images.Release is split into two PRs. This one is the first and it implements the tag
BROWSERS_IMAGE_SHORT_TAG
in preparation for the next Node.js or browser version update.A follow-on PR will provide documentation once the tag is actually available since the documentation needs to refer to concrete released versions, which are as yet undefined.
Verification
Confirm the presence of a
cypress/browsers
image with aBROWSERS_IMAGE_SHORT_TAG
such as22.11.0
.